Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support wave files with 40 byte format chunk #10001

Merged

Conversation

MarshallMiller
Copy link

@MarshallMiller MarshallMiller commented Jan 26, 2025

For some reason when I used ffmpeg to convert some 96 khz sample rate wave files from 24 bit sample size to 16 bit it decided to use a 40 byte format chunk. This patch allows the 40 byte chunk if the existing format constraints are met. I would attach the converted files but I worry about copyright issues.

The wave files that I was converting are located at:

https://www.soundonsound.com/techniques/sos-audio-test-files-downloads.

The command that I used to perform the conversion was:

ffmpeg -i "<orig-file>" -bitexact -acodec pcm_s16le "<out-file>"

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit a4e20e0 into adafruit:main Jan 27, 2025
494 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants