Adding Omnimo-nRF52840 board #10056
Open
Adding Omnimo-nRF52840 board #10056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Feb 13, 2025
Comment on lines
1
to
2
| USB_VID = 0x239A | ||
| USB_PID = 0x80DA |
There was a problem hiding this comment.
Please don't use the Adafruit USB VID.
tannewt
reviewed
Feb 21, 2025
|
Yes, we did it, truly sorry for the delayed response.
…On Fri, Feb 21, 2025 at 6:50 PM Scott Shawcroft ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ports/nordic/boards/omnimo_nrf52840/mpconfigboard.mk
<#10056 (comment)>
:
> @@ -0,0 +1,9 @@
+USB_VID = 0x1209
+USB_PID = 0xCECE
Have you made a pull request for this ID?
—
Reply to this email directly, view it on GitHub
<#10056 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOZY54DBY477IEXOVXFWQ332Q5RPBAVCNFSM6AAAAABXCKJPGKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZTHAZDKMRWHE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omnimo-nRF52840 (https://www.crowdsupply.com/eafaq/omnimo-nrf52840) is a compact, all-in-one, and easy-to-use development board that support several types of add-on modules.