Sudden Windows build failures #30
Labels
Comments
|
For comparison, this is the last Appveyor build where it did build successfully https://ci.appveyor.com/project/resin-io/etcher/build/1.0.2804/job/qf8dip3bafk0i6sj |
|
Looks like everything works if I run Based on this output, it looks like the |
jviotti
pushed a commit
to balena-io/etcher
that referenced
this issue
Mar 18, 2017
We've been recently hitting a weird `lzma-native` build error on Windows (both locally and on Appveyor CI): ``` Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch. build The input line is too long. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [C:\projects\etcher\node_modules\lzma-native\build\liblzma.vcxproj] ``` After a lot of experimentation, we realised the issue was gone if we removed `node-sass` from the development dependencies. The issue is that `node-gyp` was recently upgraded to v3.6.0, which was picked up by `node-sass`, which declares `node-gyp` as a dependency. For some reason, if `node-sass` causes `node-gyp` to be updated, then `lzma-native` fails with the above cryptic error. I was able to trace down the error to the following `node-gyp` commit: nodejs/node-gyp@ae141e1 As a solution, this commit starts to shrinkwrap development dependencies, and locks `node-gyp` to v3.5.0 until the issue is fixed. Fixes: addaleax/lzma-native#30 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
pushed a commit
to balena-io/etcher
that referenced
this issue
Mar 18, 2017
We've been recently hitting a weird `lzma-native` build error on Windows (both locally and on Appveyor CI): ``` Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch. build The input line is too long. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [C:\projects\etcher\node_modules\lzma-native\build\liblzma.vcxproj] ``` After a lot of experimentation, we realised the issue was gone if we removed `node-sass` from the development dependencies. The issue is that `node-gyp` was recently upgraded to v3.6.0, which was picked up by `node-sass`, which declares `node-gyp` as a dependency. For some reason, if `node-sass` causes `node-gyp` to be updated, then `lzma-native` fails with the above cryptic error. I was able to trace down the error to the following `node-gyp` commit: nodejs/node-gyp@ae141e1 As a solution, this commit starts to shrinkwrap development dependencies, and locks `node-gyp` to v3.5.0 until the issue is fixed. Fixes: addaleax/lzma-native#30 Signed-off-by: Juan Cruz Viotti <[email protected]>
|
@addaleax Turns out it is an issue in |
|
@jviotti Cool, thanks for letting me know. Have you opened a issued on the |
|
There you go: nodejs/node-gyp#1151, thanks a lot for the help! |
jviotti
pushed a commit
to balena-io/etcher
that referenced
this issue
Mar 20, 2017
We've been recently hitting a weird `lzma-native` build error on Windows (both locally and on Appveyor CI): ``` Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch. build The input line is too long. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [C:\projects\etcher\node_modules\lzma-native\build\liblzma.vcxproj] ``` After a lot of experimentation, we realised the issue was gone if we removed `node-sass` from the development dependencies. The issue is that `node-gyp` was recently upgraded to v3.6.0, which was picked up by `node-sass`, which declares `node-gyp` as a dependency. For some reason, if `node-sass` causes `node-gyp` to be updated, then `lzma-native` fails with the above cryptic error. I was able to trace down the error to the following `node-gyp` commit: nodejs/node-gyp@ae141e1 As a solution, this commit starts to shrinkwrap development dependencies, and locks `node-gyp` to v3.5.0 until the issue is fixed. Fixes: addaleax/lzma-native#30 See: nodejs/node-gyp#1151 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
pushed a commit
to balena-io/etcher
that referenced
this issue
Mar 20, 2017
We've been recently hitting a weird `lzma-native` build error on Windows (both locally and on Appveyor CI): ``` Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch. build The input line is too long. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [C:\projects\etcher\node_modules\lzma-native\build\liblzma.vcxproj] ``` After a lot of experimentation, we realised the issue was gone if we removed `node-sass` from the development dependencies. The issue is that `node-gyp` was recently upgraded to v3.6.0, which was picked up by `node-sass`, which declares `node-gyp` as a dependency. For some reason, if `node-sass` causes `node-gyp` to be updated, then `lzma-native` fails with the above cryptic error. I was able to trace down the error to the following `node-gyp` commit: nodejs/node-gyp@ae141e1 As a solution, this commit starts to shrinkwrap development dependencies, and locks `node-gyp` to v3.5.0 until the issue is fixed. Fixes: addaleax/lzma-native#30 See: nodejs/node-gyp#1151 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
pushed a commit
to balena-io/etcher
that referenced
this issue
Mar 20, 2017
* chore: fix `lzma-native` build issues on Windows We've been recently hitting a weird `lzma-native` build error on Windows (both locally and on Appveyor CI): ``` Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch. build The input line is too long. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [C:\projects\etcher\node_modules\lzma-native\build\liblzma.vcxproj] ``` After a lot of experimentation, we realised the issue was gone if we removed `node-sass` from the development dependencies. The issue is that `node-gyp` was recently upgraded to v3.6.0, which was picked up by `node-sass`, which declares `node-gyp` as a dependency. For some reason, if `node-sass` causes `node-gyp` to be updated, then `lzma-native` fails with the above cryptic error. I was able to trace down the error to the following `node-gyp` commit: nodejs/node-gyp@ae141e1 As a solution, this commit starts to shrinkwrap development dependencies, and locks `node-gyp` to v3.5.0 until the issue is fixed. Fixes: addaleax/lzma-native#30 See: nodejs/node-gyp#1151 Signed-off-by: Juan Cruz Viotti <[email protected]> * chore: ensure some modules in npm-shrinkwrap stay at specific versions * Address code review comments Signed-off-by: Juan Cruz Viotti <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
lzma-nativeis suddenly failing to build in all Etcher pull requests on Windows for no apparent reason. See the following build logs for an example: https://ci.appveyor.com/project/resin-io/etcher/build/job/2cfvk4dpnder5c62These are the errors we're seeing:
The above errors during
npm installfinally result in:We're shrinkwrapping our dependencies, so we're guessing the problem is caused by either a development dependency or node/npm.
I cloned this repo and checked out the 1.5.2 tag (which is the one we're using) on a Windows 10 machine running npm 3.10.10 on node v6.9.4 and got the following errors when doing
npm install ---build-from-source:To summarize, the above output prints the following error:
And the referenced file does not exist:
Do you have any clues about what might be going wrong?
The text was updated successfully, but these errors were encountered: