Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fixtures-tester to not fail when snapshot folder contains subfolder #2257

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Fix fixtures-tester to not fail when snapshot folder contains subfolder #2257

merged 2 commits into from
Apr 20, 2021

Conversation

jaroslav-kubicek
Copy link
Contributor

Motivation: When fixture folder contains some another subfolder, it fails on readFileSync with EISDIR: illegal operation on a directory error.

@jaroslav-kubicek jaroslav-kubicek requested a review from a team as a code owner April 20, 2021 13:02
@jaroslav-kubicek
Copy link
Contributor Author

looks like it fails on unrelated changes, I get the error even by adding a white space

mrtnzlml
mrtnzlml approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@mrtnzlml mrtnzlml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrtnzlml
Copy link
Member

looks like it fails on unrelated changes, I get the error even by adding a white space

I removed the problematic tests. Feel free to rebase and try it again - it should be fine.

@mrtnzlml mrtnzlml mentioned this pull request Apr 20, 2021
Merged
1 task
@vercel vercel bot temporarily deployed to Preview – universe-example-relay April 20, 2021 17:20 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website April 20, 2021 17:20 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website April 20, 2021 17:23 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay April 20, 2021 17:23 Inactive
@kodiakhq kodiakhq bot merged commit ac6d91f into master Apr 20, 2021
@kodiakhq kodiakhq bot deleted the fix-fixtures-tester branch April 20, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrtnzlml mrtnzlml mrtnzlml approved these changes

@michalsanger michalsanger Awaiting requested review from michalsanger

@tbergquist-godaddy tbergquist-godaddy Awaiting requested review from tbergquist-godaddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaroslav-kubicek @mrtnzlml