Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create test messages #13

Closed
erwinspeybroeck opened this issue Jun 19, 2019 · 5 comments
Closed

create test messages #13

erwinspeybroeck opened this issue Jun 19, 2019 · 5 comments
Assignees
Labels
stale-issue Identifies that an issue is stale and will be closed unless reactivated.

Comments

@erwinspeybroeck
Copy link
Collaborator

dummy messages in github so they can be accessed

@ahokkonen
Copy link
Contributor

example messages could be nested as part of "exampleUrlSchema" (inside each path's response or in components section) file or in separate files. I suggest we create separate example files for each event and add them as external component references into schema. With that approach will keep original schema clear.

@cookeac
Copy link
Collaborator

cookeac commented Dec 12, 2019

Yes, I like this approach. It also allows other organizations to define alternative url approaches for different purposes but reuse the examples. The example files themselves will assist with understanding so should be linked or referenced from any documentation.

@ahokkonen
Copy link
Contributor

should examples be isolated form core files into own sub-folder - "examples" inside "Release Candidate Messages"? For each event there probably should be own example file aka. "IseminationEventExamples.json", "DryOffEventExamples"?

@cookeac
Copy link
Collaborator

cookeac commented Feb 28, 2020

Discussed in https://github.com/adewg/ICAR/wiki/Technical-Minutes-2020-01-31
@ahokkonen is contributing some example data for Finland.

erwinspeybroeck pushed a commit that referenced this issue Jul 30, 2020
Merge from ADEWG/ICAR/Develop
@stale
Copy link

stale bot commented Sep 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-issue Identifies that an issue is stale and will be closed unless reactivated. label Sep 23, 2021
@stale stale bot closed this as completed Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale-issue Identifies that an issue is stale and will be closed unless reactivated.
Projects
None yet
Development

No branches or pull requests

3 participants