Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Type for Coat Color #240

Closed
ghost opened this issue Aug 12, 2021 · 4 comments · Fixed by #252
Closed

Alternative Type for Coat Color #240

ghost opened this issue Aug 12, 2021 · 4 comments · Fixed by #252
Labels
this-release Scheduled to be implemented for this release in development

Comments

@ghost
Copy link

ghost commented Aug 12, 2021

As mentioned in our meeting on 12.08.2021:

The coatColor property of the icarAnimalCoreResource.json states:
Colour of the animal's coat, using the conventions for that breed.

That is not very helpful as it seems to imply that the primary breed scheme/identifier should have an influence on this. As discussed, there would be two ways on how we can improve this:

  1. change the coatColor to contain an enum value (have to make a list of all possible coat colors and each receiving party has to maintain a mapping from possible coat colors to its own list of allowed values)
  2. use scheme/identifier instead to allow for different enumerations per country/organization/... (but we could still provide a default scheme, if we want to)

Any opinions which way to go?

We should also decide if this should be solved in a 1.x release, because then we have to add an additional field for the new coat color to be backwards-compatible and might have to rename it for a 2.x version.

@erwinspeybroeck
Copy link
Collaborator

Color codes in Netherlands:
[ BLACK, BLACK_AND_WHITE, BLACK_WHITE, BLACK_SPOTTED_PIED, BLUE_AND_WHITE, BROWN, FAWN_PIED, GRAY, RED, RED_AND_WHITE, RED_WHITE, RED_SPOTTED_PIED, TRICOLOR, WHITE, WHITEBACKED_RED, WHITEBACKED_BLACK, WHITEHEADED_RED, WHITEHEADED_BLACK ]

Color codes in Belgium:
[ BLACK, BLACK_AND_WHITE, BLUE_AND_WHITE, GRAY, RED, RED_AND_WHITE, WHITE, DARK_BROWN, LIGHT_BROWN, MICE_BROWN, WHITE_AND_BLACK, WHITE_AND_BLUE, WHITE_AND_RED ]

In Belgium color codes are really only I&R related, in the Netherlands the breeding organisation had more to say ;-)

@ghost
Copy link
Author

ghost commented Aug 12, 2021

From LKV in NRW/Germany (ADIS Dictionary):

http://ian.lkv-nrw.de/index.php?id=292&vURL=AGRO2018%2Fc810026.html&cHash=82f66ea378

[ Other, Black, Brown, Red, Gray (as the color), White, Saddled (? "gesattelt"), ("Schimmel" = completely white), Blonde, False Color ("Fehlfarbe")]

@ghost
Copy link
Author

ghost commented Aug 12, 2021

Maybe one thing in favor of schema/identifier: I guess sheep, horses, pigs, cows etc. might have highly different coat color values. Therefore, the question is for me whether a large enum of all values makes really sense because you then need to map specific pig or horse colors even if you only want to exchange cow data...

@AndreasSchultzGEA
Copy link
Collaborator

PR at #252

@cookeac cookeac added the this-release Scheduled to be implemented for this release in development label Oct 7, 2021
cookeac added a commit that referenced this issue Oct 7, 2021
Add CoatColorDetails in IcarAnimalCoreResource. Resolves #240
@cookeac cookeac linked a pull request Oct 7, 2021 that will close this issue
@cookeac cookeac closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
this-release Scheduled to be implemented for this release in development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants