Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing patch release 1.3.2 prior to release #364

Closed
cookeac opened this issue Feb 9, 2023 · 3 comments · Fixed by #367
Closed

Testing patch release 1.3.2 prior to release #364

cookeac opened this issue Feb 9, 2023 · 3 comments · Fixed by #367
Assignees

Comments

@cookeac
Copy link
Collaborator

cookeac commented Feb 9, 2023

Hi everyone,

As many of you will know, after the release of 1.3 (and the fix to withholding event in 1.3.1) a few more problems were discovered with ADE 1.3. These were:
#353 Problem with icarStatistics
#357 AnyOf causes problem with code generation in icarConsignmentType origin and destination addresses.
We also resolved we needed release notes to explain the discriminator changes in 1.3. (#358). I have put this in a release notes MD and link to it from the main readme. I added some text to explain the fixes above.

We believe we have now addressed the above with commits to the branch https://github.com/adewg/ICAR/tree/RC-for-ADE-1-3-2
We would like to test this promptly so it can be released. If you have access to code generation tools, can you please test this branch and report your results so we can merge the branch into both ADE1 (new release 1.3.2) and back into the Develop branch.

Thanks,
Andrew.

@cookeac
Copy link
Collaborator Author

cookeac commented Feb 12, 2023

Adding developers with C# and Java, let me know if you haven't got time.

@AlexeyHardCode
Copy link
Collaborator

C# code generation looks just as expected:
image

Also icaStatisticType model code generation is valid.

@AndreasSchultzGEA
Copy link
Collaborator

Java-Code for Consignment seems to be ok.
The code for IcarStatisticType could not be testet, as we don't have implemented this parts so far.

PostalAdress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants