Tested changes for ADE 1.3.2 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Include "allOf" icarResource so the normal resource synchronisation etc works. 2. Move "statistics" array inside icarStatisticsGroupType - change made by @erwinspeybroeck 3. Add some more "description" values to explain the intent of the attributes. Resolves #353
And added links to the other guidance markdown files in docs.
removd statistics from the required section
made unit as a string and value just as number (without float and nullable)
initial version
And updated the description of the units field.
Revert consignment originAddress and destinationAddress to simple string types, as using "anyOf" with string and PostalAddress options did not work for Java code generation.
Return `originAddress` and `destinationAddress` to string fields to avoid breaking changes in code generation, but also mark these as deprecated. Add `originPostalAddress` and `destinationPostalAddress` as structured addresses. Resolves #357
Added release notes explaining 1.3 changes and linked to them from the main readme.
|
This has already been reviewed by the technical working group, but our process requires a review, so linking in @erwinspeybroeck for a quick approval. |
|
in the milkUrlScheme: Rest is ok for me |
in the milkUrlScheme: "operationId": "get existing milking-withdrawals", should be "operationId": "get-existing-milking-withdrawals",
|
Correction made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request integrates the following changes:
icarStatisticsResourceand related resources - resolves icarStatistics API is not ok #353icarConsignmentTypeaddress fields - resolves AnyOf causes code generation problem in icarConsignmentType #357