Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resources for conformation score event (#97) #133

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Added resources for conformation score event (#97) #133

merged 3 commits into from
Jul 29, 2020

Conversation

ahokkonen
Copy link
Contributor

@ahokkonen ahokkonen commented Jul 29, 2020

Proposal for conformation score event.

  • one score per trait
  • score value can be decimal
  • all possible traits (for dairy and dual purpose) combined in one enumeration
  • automated/manual scoring methods allowed
  • included "device" for referencing device information in case of automated scoring

TODO: examples to be added

Resolves #97

Anton Hokkonen and others added 3 commits July 29, 2020 10:35
#97
added resources for conformation scores
-replaced device resource with device reference type
@cookeac
Copy link
Collaborator

cookeac commented Jul 29, 2020

This looks great. I particularly like that the list of possible traits are combined and species/purpose independent (because the species or purpose will be known from the animal/location). I will merge as is, but we should think about:
a. Whether "trait" might be confusing as there is also a "traitLabel" in the event base class (but I wouldn't suggest a major change, perhaps traitScored....).
b. Have we checked the other species conformation trait types (as per the same ICAR Guidelines document) to ensure we have a complete list (from memory, the cattle ones were effective for all species).

@cookeac cookeac merged commit 45cfd1a into adewg:Develop Jul 29, 2020
@ahokkonen
Copy link
Contributor Author

@cookeac

I agree, we can change property name to "traitScored" or "conformationTrait" to avoid confusions.
I'll check traits list for including types for all species described in guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants