Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix Spectral paths #294

Merged
merged 1 commit into from
May 5, 2022
Merged

Attempt to fix Spectral paths #294

merged 1 commit into from
May 5, 2022

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Apr 21, 2022

The updated spectral code needed a ruleset parameter, which Anton had attempted to specify using an environment variable to choose the appropriate ruleset for Develop/ADE-1, etc.

This has been broken for a few months, so I am attempting to fix this. According to the documentation, you should use Linux bash syntax, not GitHub syntax when referencing environment variables in the run statement. So I am using $SPECTRAL_RULESET rather than {{env.SPECTRAL_RULESET}}.

The updated spectral code needed a ruleset parameter, which Anton had attempted to specify using an environment variable to choose the appropriate ruleset for Develop/ADE-1, etc. 

This has been broken for a few months, so I am attempting to fix this. According to the documentation, you should use ubuntu syntax, not GitHub syntax when referencing environment variables in the **run** statement. So I am using $SPECTRAL_RULESET rather than {{env.SPECTRAL_RULESET}}.
@cookeac cookeac linked an issue Apr 22, 2022 that may be closed by this pull request
@cookeac
Copy link
Collaborator Author

cookeac commented May 5, 2022

I'm going to try and merge this, because its not possible to test this without a commit.

@cookeac cookeac merged commit 9ebdb01 into Develop May 5, 2022
@cookeac cookeac deleted the spectral-patch branch May 5, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix request for spectral linter
1 participant