Erwinspeybroeck #284 #298
Merged
Erwinspeybroeck #284 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statistics API is added to the managment section
array's were not well defined
parameters changed for better use in combination with statistics
metric -> scheme instead of enum enums in camelcase type denominator
it seems statistics is not being rendered. Try to find out why ...
value ok, now added aggregation
added the rest, probably a missing comma ...
Created to be used instead of icarGroupType.json icarGroupType.json was used also in the enums section ...
use of icarStatisticsGroupType instead of icarGroupType
has been interchanged with icarStatisticsGroupType
made all fields required. One needs to know the location, purpose, the period, eventual group info and statistics
equal to the filter parameters
added some documentation
added some documentation
cookeac
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #184 First version of the statistics resource