Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Speccy and Spectral linting errors and warnings #313

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Aug 25, 2022

There were a number of Speccy and Spectral errors and warnings that are worth looking into now that Spectral is running again.
In this pull request I've addressed some of these:

  • Addressed tag warnings in the URL scheme files, and updated all tags to ADE-1.3-*
  • icarHealthStatusObservedEventCollection.json didn't exist - created this
  • icarResourceReferenceType.json had "identifier" specified incorrectly using "type" when it should have been "$ref" - corrected.
  • Addressed unused section warnings in the URL scheme files - animal-scheme and animal-id only make sense in the registration URL scheme where you can query an animal given its ID. Other schemes don't currently use these parameters (but could?).

There are still errors about "type" property must be equal to one of the allowed values: "array", "boolean", "integer", "number", "object", "string". in a number of collection files. This seems to be spurious, and indeed when I reproduce this by running Spectral locally in the VS Code extension, when it hits one of these Spectral stops with an error and directs me to look at its output. The actual JSON Schema looks correct - there is an array, and the error occurs at the start of the "items" clause, not in the "type" clause. It doesn't even work if items is a simple type.

@cookeac cookeac requested review from erwinspeybroeck and AndreasSchultzGEA and removed request for erwinspeybroeck September 7, 2022 08:01
@cookeac
Copy link
Collaborator Author

cookeac commented Sep 8, 2022

Approved at meeting

@cookeac cookeac merged commit e1d07b3 into adewg:Develop Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant