-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parentage to icarAnimalCore, add Movement events. #32
Conversation
Merge from ADE-WG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Andrew,
I went through the pull request. I have 2 remarks.
- regarding departure reasons : we use it now in a bit another way than your proposal. We have the following reasons: 3 = age, 4 = superfluous, 5 = fattened / ready for slaughter, 10 = leg/claw problems, 11 = nutrition disorders, 12 = calving problems, 13 = high scc/mastitis, 14 = fertility,19 = health problems, 20 = low production, 21 = milking ability, 22 = bad type, 23 = behaviour, 24 = export, 25 = sale for live, 26 = NUKA (as a new born calf), 27 = other. We use this in management overviews for the farmer.
- The local I&R data : I suppose we don't put them in the standard and they should be added when needed?
Another remark - shouldn't we also add registration API's to the example url file?
Hi Erwin,
|
I have added coatColour to icarAnimalCoreResource.
|
|
Andrew, I agree on splitting departure reasons in 2 sets - is more in line with the deathReasons - let's see how the others react? Regarding I&R: Regarding the example url schema's : I will process your pull request, and I will add urls to the example url file. kind regards, Erwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, I could open it again and approved merging
No description provided.