-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add of withdrawal-resources #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting a bit more detail in description to help people understand types of use cases. I also wondered if this should be just a resource or an event - I think either could work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also ok for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreasSchultzGEA GitHub says that the branch has conflicts that must be resolved.
The issue is simply that the milkURLScheme.json in this PR has different tab indentation on its lines than that in the Develop branch. Therefore it looks like every line has changed, while in the meantime there have been minor changes to the version in the Develop branch. I think if you reformat this file with the smaller spacing that is in the existing file, it should merge fine.
Also there is a warning on line 519 - the "operation" for "get existing milking-withdrawals" must not have spaces (currently it does have spaces).
I tried to make the changes and add them to your branch, but of course I don't have permission.
# Conflicts: # url-schemes/milkURLScheme.json
finally, I re-fixed the formatting |
Adds withdrawal resource, resolves #318 |
No description provided.