Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add of withdrawal-resources #320

Merged
merged 8 commits into from
Sep 16, 2022
Merged

Conversation

AndreasSchultzGEA
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@cookeac cookeac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a bit more detail in description to help people understand types of use cases. I also wondered if this should be just a resource or an event - I think either could work.

Copy link
Collaborator

@cookeac cookeac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@AndreasSchultzGEA AndreasSchultzGEA changed the title added the withdrawal-resources and an example for an interface Add of withdrawal-resources Sep 14, 2022
Copy link
Collaborator

@erwinspeybroeck erwinspeybroeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also ok for me

Copy link
Collaborator

@cookeac cookeac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreasSchultzGEA GitHub says that the branch has conflicts that must be resolved.
The issue is simply that the milkURLScheme.json in this PR has different tab indentation on its lines than that in the Develop branch. Therefore it looks like every line has changed, while in the meantime there have been minor changes to the version in the Develop branch. I think if you reformat this file with the smaller spacing that is in the existing file, it should merge fine.

Also there is a warning on line 519 - the "operation" for "get existing milking-withdrawals" must not have spaces (currently it does have spaces).

I tried to make the changes and add them to your branch, but of course I don't have permission.

@AndreasSchultzGEA
Copy link
Collaborator Author

finally, I re-fixed the formatting

@cookeac cookeac linked an issue Sep 16, 2022 that may be closed by this pull request
@cookeac cookeac merged commit 236929a into adewg:Develop Sep 16, 2022
@cookeac
Copy link
Collaborator

cookeac commented Sep 16, 2022

Adds withdrawal resource, resolves #318

@cookeac cookeac mentioned this pull request Sep 16, 2022
@AndreasSchultzGEA AndreasSchultzGEA deleted the product_withdrawals branch November 9, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separation of Milk
3 participants