Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erwinspeybroeck #330

Merged
merged 13 commits into from
Oct 6, 2022
Merged

Erwinspeybroeck #330

merged 13 commits into from
Oct 6, 2022

Conversation

erwinspeybroeck
Copy link
Collaborator

Made the example url consistent with the other urls

Copy link
Collaborator

@cookeac cookeac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needed to fix a linting error in exampleUrlScheme.json (we actually need the same change in milkURLScheme.json too, but that is not in this PR).

@cookeac cookeac linked an issue Oct 3, 2022 that may be closed by this pull request
cookeac added a commit to cookeac/ICAR that referenced this pull request Oct 3, 2022
changed to "type": "number", "format": "double", as "double" is not a valid JSON Schema type.
Discovered from Speccy validation error in PR adewg#330
@cookeac cookeac requested a review from AlexeyHardCode October 6, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that exampleURLScheme is complete with resource types for 1.3
3 participants