-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group weigh event #333
Conversation
Add icarGroupWeightEventResource, icarIndividualWeightType, and icarGroupWeightEventCollection. Resolves adewg#332
Add icarGroupTreatmentEventCollection.json and put group health treatments into healthURLScheme.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks logical to me - more of the same stuff.
Didn't dive into it very deep
"items": { | ||
"$ref": "../resources/icarGroupTreatmentEventResource.json" | ||
}, | ||
"description": "Provides the array of objects, in this case weighing events." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
treatment instead of weighing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct - an afterthought but see the bottom line of the PR description. I went to update the collections and noted the the group treatment event collection didn't exist.
{ | ||
"type": "object", | ||
"properties": { | ||
"units": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
singular?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a) English would only use "unit" if the value was singular, which it mostly will not be. Also like this for consistency with icarMassMeasureType.units
.
}, | ||
"description": "Array of animal id and weight pairs for animals in the event." | ||
}, | ||
"statistics": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this to relate to animalWeights.
But unsure why this is an Array!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two arrays in this resource:
- An array of statistics (e.g. min, max, mean, standard deviation, coefficient of variation, or anything else you like
- An array of raw data, which coming from devices may have just weights, or some values with IDs (which I'd prefer were individual animal events, but sometimes are not). The raw data (if provided) is what was analysed to produce the statistics for the event.
Define a group weigh event that has statistics about a group weighing, and optionally has an array of weights/IDs (we expect mostly this will just be weights or empty, but there's a case for animal IDs if they are returned by scales for a sample of animals in a group).
Added these group events to performanceURLSchema.json
Resolves #332
Also: Add icarGroupTreatmentCollection.json and add treatment group events to healthURLScheme.json.