Add group weigh event #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add icarGroupWeightEventResource, icarIndividualWeightType, and icarGroupWeightEventCollection. Resolves adewg#332
Add icarGroupTreatmentEventCollection.json and put group health treatments into healthURLScheme.json
erwinspeybroeck
approved these changes
Oct 5, 2022
| "items": { | ||
| "$ref": "../resources/icarGroupTreatmentEventResource.json" | ||
| }, | ||
| "description": "Provides the array of objects, in this case weighing events." |
There was a problem hiding this comment.
treatment instead of weighing
There was a problem hiding this comment.
Correct - an afterthought but see the bottom line of the PR description. I went to update the collections and noted the the group treatment event collection didn't exist.
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "units": { |
There was a problem hiding this comment.
a) English would only use "unit" if the value was singular, which it mostly will not be. Also like this for consistency with icarMassMeasureType.units.
| }, | ||
| "description": "Array of animal id and weight pairs for animals in the event." | ||
| }, | ||
| "statistics": { |
There was a problem hiding this comment.
I suppose this to relate to animalWeights.
But unsure why this is an Array!?
There was a problem hiding this comment.
Two arrays in this resource:
- An array of statistics (e.g. min, max, mean, standard deviation, coefficient of variation, or anything else you like
- An array of raw data, which coming from devices may have just weights, or some values with IDs (which I'd prefer were individual animal events, but sometimes are not). The raw data (if provided) is what was analysed to produce the statistics for the event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a group weigh event that has statistics about a group weighing, and optionally has an array of weights/IDs (we expect mostly this will just be weights or empty, but there's a case for animal IDs if they are returned by scales for a sample of animals in a group).
Added these group events to performanceURLSchema.json
Resolves #332
Also: Add icarGroupTreatmentCollection.json and add treatment group events to healthURLScheme.json.