Fix open api spec linting errors #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Erwin's changes to the YAML file have removed these items back to the JSON schema files (now included by reference) and we have checked that these descriptions are in place in those files. |
erwinspeybroeck
pushed a commit
that referenced
this pull request
Aug 19, 2019
Adding swagger endpoints
erwinspeybroeck
pushed a commit
that referenced
this pull request
Apr 22, 2020
Merge from adewg/ICAR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I linted the icar-ade-openapispec yaml using the speccy linter (http://speccy.io/) which found a non-resolving url reference (see #7) and that the milking-visit-id parameter of many methods was missing a description. Description for this parameter was populated from icarMilkingVisitResource.json