Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XENG-8914 include last element in run_config_file in network name, if… #185

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

jacobtruman
Copy link
Member

@jacobtruman jacobtruman commented Mar 7, 2025

… it exists

In the case of a parallel Jenkins job that calls buildrunner multiple times for different buildrunner.yaml files with the same step names, but in different directories, a network name will be unique to the buildrunner.yaml file directory

What does this PR do?

What issues does this PR fix or reference?

Previous Behavior

New Behavior

Merge requirements satisfied?

  • I have updated the documentation or no documentation changes are required.
  • I have added tests to cover my changes.
  • I have updated the base version in setup.py (if appropriate).

@@ -82,6 +82,8 @@ def __init__(
self.container_labels = container_labels
# network name is used to identify the network that the build step is running in
self.network_name = f"{build_runner.build_id}-{step_name}"
if build_runner.run_config_file:
self.network_name += f"-{os.path.basename(os.path.dirname(os.path.abspath(build_runner.run_config_file)))}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not generate a random ID here? What if they are in subdirectories that match the name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds better...

@jacobtruman jacobtruman merged commit 6faf978 into adobe:main Mar 7, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants