XENG-8914 include last element in run_config_file in network name, if… #185
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesliverx
reviewed
Mar 7, 2025
buildrunner/steprunner/__init__.py
Outdated
| @@ -82,6 +82,8 @@ def __init__( | |||
| self.container_labels = container_labels | |||
| # network name is used to identify the network that the build step is running in | |||
| self.network_name = f"{build_runner.build_id}-{step_name}" | |||
| if build_runner.run_config_file: | |||
| self.network_name += f"-{os.path.basename(os.path.dirname(os.path.abspath(build_runner.run_config_file)))}" | |||
There was a problem hiding this comment.
Why not generate a random ID here? What if they are in subdirectories that match the name?
There was a problem hiding this comment.
that sounds better...
bluesliverx
approved these changes
Mar 7, 2025
shanejbrown
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… it exists
In the case of a parallel Jenkins job that calls buildrunner multiple times for different buildrunner.yaml files with the same step names, but in different directories, a network name will be unique to the buildrunner.yaml file directory
What does this PR do?
What issues does this PR fix or reference?
Previous Behavior
New Behavior
Merge requirements satisfied?
setup.py(if appropriate).