Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UUID for unique key #115

Closed
wants to merge 1 commit into from
Closed

Use UUID for unique key #115

wants to merge 1 commit into from

Conversation

Syer10
Copy link
Contributor

@Syer10 Syer10 commented Mar 11, 2023

This fixes an issue with Android where if the app is killed but then restored, the AtomicInt restarts at 0. This will guarantee uniqueness between app restarts.

Copy link

@jfirebase jfirebase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DevSrSouza
Copy link
Collaborator

Hi @Syer10 this for the PR and the report of the error, I go though a diferent direction in this first version, I still using UUID but I'm using for JVM and Native, the platform calls, and for JS I'm using the library.

This is the commit.
f1487d3

This PR will still be reference on the release notes, thanks for the finding and the solution!

@DevSrSouza DevSrSouza closed this Apr 24, 2023
@Syer10 Syer10 deleted the uuid branch May 7, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants