Hilt integration #13
Merged
Hilt integration #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support to assisted injection with screen model
adrielcafe
reviewed
Oct 2, 2021
voyager-hilt/src/main/java/cafe/adriel/voyager/hilt/ScreenFactory.kt
Outdated
Show resolved
Hide resolved
adrielcafe
reviewed
Oct 2, 2021
voyager-hilt/src/main/java/cafe/adriel/voyager/hilt/ScreenFactoryKey.kt
Outdated
Show resolved
Hide resolved
adrielcafe
reviewed
Oct 2, 2021
voyager-hilt/src/main/java/cafe/adriel/voyager/hilt/ScreenModelEntryPoint.kt
Outdated
Show resolved
Hide resolved
adrielcafe
reviewed
Oct 2, 2021
voyager-hilt/src/main/java/cafe/adriel/voyager/hilt/ScreenModel.kt
Outdated
Show resolved
Hide resolved
adrielcafe
reviewed
Oct 2, 2021
voyager-hilt/src/main/java/cafe/adriel/voyager/hilt/ScreenModel.kt
Outdated
Show resolved
Hide resolved
adrielcafe
reviewed
Oct 2, 2021
voyager-hilt/src/main/java/cafe/adriel/voyager/hilt/ScreenModel.kt
Outdated
Show resolved
Hide resolved
adrielcafe
reviewed
Oct 2, 2021
Comment on lines
19
to
27
| val componentActivity = context as? ComponentActivity | ||
| ?: throw IllegalStateException("Invalid local context on AndroidScreen. It must be a ComponentActivity") | ||
| val androidScreenLifecycleOwner = getLifecycleOwner() as? AndroidScreenLifecycleOwner | ||
| ?: throw IllegalStateException( | ||
| "Invalid LifecycleOwner on AndroidScreen. It must be an AndroidScreenLifecycleOwner" | ||
| ) | ||
| val provider = ViewModelProvider( | ||
| androidScreenLifecycleOwner.viewModelStore, | ||
| viewModelProviderFactory ?: componentActivity.defaultViewModelProviderFactory |
There was a problem hiding this comment.
Since componentActivity is used as fallback, is better to avoid a premature throw with something like:
private val Context.defaultViewModelProviderFactory: ViewModelProvider.Factory
get() = (this as? ComponentActivity)?.defaultViewModelProviderFactory
?: error("Invalid local context on AndroidScreen. It must be a ComponentActivity")```` There was a problem hiding this comment.
Moved this content to a ContextExt.kt because we need a activity and it default view model provider factory
|
It's great, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Hilt support #11 . For now the support are using Multibinding to have a flexible approach. There is a basic support to Assisted Injection and to reuse your existing HiltViewModel too. HIltViewModel has no support to Asssited Injection.
All implementations are using Voyager ViewModelStore instead of Activity ViewModelStore to clear ViewModels on navigation pop.
Improvements and how to test will come soon.
To see working run the sample and start Hilt intregation.