Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: find activity when inside compose custom view in legacy code #22

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

programadorthi
Copy link
Collaborator

@programadorthi programadorthi commented Oct 19, 2021

Some users can use Voyager inside androidx.compose.ui.platform.ComposeView. Context inside custom View are ContextWrapper and cast it to ComponentActivity is always fail. #20 This PR try to find topmost ComponentActivity context if there is one.

@adrielcafe
Copy link
Owner

Thanks again!

@adrielcafe adrielcafe merged commit eb3a6c0 into main Dec 16, 2021
@adrielcafe adrielcafe deleted the fix/custom-view-context branch December 16, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beta13 hiltviewmodel crash when navigating back to same destination
2 participants