Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplatform Voyager #33

Merged
merged 7 commits into from
Dec 16, 2021
Merged

Multiplatform Voyager #33

merged 7 commits into from
Dec 16, 2021

Conversation

terrakok
Copy link
Contributor

@terrakok terrakok commented Dec 13, 2021 •
edited
Loading

I've migrated voyager-core to Kotlin Multiplatform with Android+JVM targets.

@terrakok terrakok force-pushed the multiplatform-compose branch from 210fbd4 to fcec276 Compare December 13, 2021 16:52
@terrakok
Copy link
Contributor Author

Done. It can be merged to master. The Core and the Navigator modules can be used in desktop compose apps

@terrakok
Copy link
Contributor Author

Sample desktop app with Voyager navigation:
https://github.com/Kotlin/kmm-production-sample/blob/8985e952b72f4ff619ac9db9d2c4e0b2377ae8a7/composeApp/src/jvmMain/kotlin/com/github/jetbrains/rssreader/desktopApp/App.kt#L61

P.S.: before launch you have to publish Voyager version 2.0.0 to MavenLocal

@terrakok
Copy link
Contributor Author

screen-recording-2021-12-14-at-164029_Shj2ry5l.mp4

@adrielcafe
Copy link
Owner

Thanks for your contribution @terrakok !

@adrielcafe adrielcafe merged commit 3de110c into adrielcafe:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrielcafe adrielcafe adrielcafe approved these changes

@programadorthi programadorthi programadorthi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrakok @adrielcafe @programadorthi