feat: Make modules truly Multiplatform by moving to commonMain #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevSrSouza
commented
Jan 13, 2022
Comment on lines
+13
to
+14
| internal fun Screen.commonKeyGeneration() = | ||
| this::class.qualifiedName ?: error("Default ScreenKey not found, please provide your own key") |
There was a problem hiding this comment.
This was required because Kotlin currently does not support default implementation on expect classes. You can follow issue here https://youtrack.jetbrains.com/issue/KT-20427
DevSrSouza
force-pushed
the
feat/multiplatform-common
branch
from
08cdb75 to
1cb857a
Compare
adrielcafe
approved these changes
Jan 30, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation from @programadorthi works on branch feat/core-multiplatform-common.
This PR moves the following modules to commonMain: