Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elsevier references - uncaught references #155

Open
ehenneken opened this issue Dec 18, 2024 · 4 comments
Open

Elsevier references - uncaught references #155

ehenneken opened this issue Dec 18, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ehenneken
Copy link
Member

Describe the bug
The reference parser currently only catches references in tags like <sb:reference id="sbref0036">. References in other tags are not caught, like <ce:other-ref id="sbref0037">

Example: 2022AgFM..32209026M

@ehenneken ehenneken added the bug Something isn't working label Dec 18, 2024
@seasidesparrow
Copy link
Member

seasidesparrow commented Dec 20, 2024

@ehenneken Am I correct in thinking you don't want to capture all <sb:reference> and <ce:other-ref> tags, just the unique ones? In this example, most are duplicates, except for 0037, 0039

@ehenneken
Copy link
Member Author

@seasidesparrow I should have formulated the bug as: currently, not all references are caught. The reference section in the full text XML has references with id sbref0001 thru, say, sbref0089. All of these references must be extracted and saved in the reference data file. It looks like 0016 is missing too, besides 0037 and 0039

@seasidesparrow
Copy link
Member

@ehenneken This is a straightforward fix, but the tag structure is different between the two. The downstream elsevier ref parser would need to look for both the <sb:reference> tag and the <ce:other-ref> tag. Is that acceptable?

@ehenneken
Copy link
Member Author

@seasidesparrow That sounds like a simple fix in the reference handler, so yes, please go ahead and implement the fix. Let me know when the Elsevier references have been re-extracted with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants