Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scix 491 enable abs graphics #600

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

shinyichen
Copy link
Member

Enable checking abstract graphics and metrics for the navigation menu.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 66.2%. Comparing base (950d302) to head (76af2bd).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/components/AbstractSideNav/AbstractSideNav.tsx 18.8% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #600     +/-   ##
========================================
+ Coverage    66.0%   66.2%   +0.2%     
========================================
  Files         198     203      +5     
  Lines       22347   22839    +492     
  Branches      602     621     +19     
========================================
+ Hits        14747   15112    +365     
- Misses       7588    7715    +127     
  Partials       12      12             
Files with missing lines Coverage Δ
...c/components/NavigationMenu/SideNavigationMenu.tsx 19.0% <ø> (+0.4%) ⬆️
src/components/AbstractSideNav/AbstractSideNav.tsx 22.9% <18.8%> (-0.1%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@shinyichen shinyichen merged commit 30164ec into adsabs:master Mar 12, 2025
4 checks passed
@shinyichen shinyichen deleted the SCIX-491-enable-abs-graphics branch March 12, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants