Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pagination ui look consistent #602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shinyichen
Copy link
Member

Update all pagination UI to look consistent with the pagination from search results.

Screenshot 2025-03-12 at 2 28 08 PM

@shinyichen shinyichen requested a review from thostetler March 12, 2025 21:28
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 19.25466% with 130 lines in your changes missing coverage. Please review.

Project coverage is 66.0%. Comparing base (e2eb812) to head (4122931).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Pagination/ManualPageSelect.tsx 22.2% 88 Missing ⚠️
...onents/Pagination/ControlledPaginationControls.tsx 9.6% 19 Missing ⚠️
src/components/Pagination/PaginationControls.tsx 9.6% 19 Missing ⚠️
src/theme.ts 33.4% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #602     +/-   ##
========================================
- Coverage    66.1%   66.0%   -0.0%     
========================================
  Files         198     204      +6     
  Lines       22342   22931    +589     
  Branches      604     620     +16     
========================================
+ Hits        14747   15127    +380     
- Misses       7583    7792    +209     
  Partials       12      12             
Files with missing lines Coverage Δ
src/theme.ts 86.3% <33.4%> (-3.4%) ⬇️
...onents/Pagination/ControlledPaginationControls.tsx 18.8% <9.6%> (+1.9%) ⬆️
src/components/Pagination/PaginationControls.tsx 18.5% <9.6%> (+2.3%) ⬆️
src/components/Pagination/ManualPageSelect.tsx 22.2% <22.2%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant