Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some TODOs #1315

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Remove some TODOs #1315

merged 1 commit into from
Mar 9, 2025

Conversation

Haselnussbomber
Copy link
Contributor

No description provided.

@Haselnussbomber Haselnussbomber force-pushed the remove-todos branch 2 times, most recently from c3fe447 to b0de142 Compare March 9, 2025 16:50
Copy link
Contributor

github-actions bot commented Mar 9, 2025

Breaking Changes

Type exists in left but not in right

FFXIVClientStructs.FFXIV.Client.UI.Agent: 1

AgentModule: 1

  • UIModuleAgentModulePtrStruct

FFXIVClientStructs.FFXIV.Client.UI: 1

Agent: 1

  • AgentRequest

Member exists in left but not in right

FFXIVClientStructs.FFXIV.Client.UI: 3

RaptureAtkModule: 1

  • System.Span<FFXIVClientStructs.FFXIV.Client.UI.RaptureAtkModule.InventoryCache> InventoryItemCache

UIModule: 1

  • FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentModule.UIModuleAgentModulePtrStruct* GetUIModuleAgentModulePtr()

UIModuleInterface: 1

  • FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentModule.UIModuleAgentModulePtrStruct* GetUIModuleAgentModulePtr()

FFXIVClientStructs.FFXIV.Component.Exd.ExdModule.Delegates: 1

GetBannerConditionUnlockState: 2

  • byte Invoke(void*)
  • byte EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Component.Exd: 1

ExdModule: 1

  • byte GetBannerConditionUnlockState(void*)

FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentColorant: 1

ColorantCharaView: 2

  • bool IsAnimationPaused()
  • void ToggleAnimationPlayback(bool)

FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentGearSet: 1

GearsetCharaView: 2

  • bool IsAnimationPaused()
  • void ToggleAnimationPlayback(bool)

FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentInspect: 1

InspectCharaView: 2

  • bool IsAnimationPaused()
  • void ToggleAnimationPlayback(bool)

FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentInventoryContext.Delegates: 1

UseItem: 2

  • long Invoke(FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentInventoryContext*, uint, uint, uint, short)
  • System.IAsyncResult BeginInvoke(FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentInventoryContext*, uint, uint, uint, short, System.AsyncCallback, object)

FFXIVClientStructs.FFXIV.Client.UI.Agent: 4

AgentInventoryContext: 1

  • long UseItem(uint, uint, uint, short)

AgentModule: 2

  • FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentModule.UIModuleAgentModulePtrStruct UIModuleAgentModulePtr
  • FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentRequest* GetAgentRequest()

AgentId: 1

  • FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentId Request

AgentSalvage: 1

  • void ItemListRefresh()

FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentMiragePrismMiragePlate: 1

MiragePrismMiragePlateCharaView: 2

  • bool IsAnimationPaused()
  • void ToggleAnimationPlayback(bool)

FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentSalvage.Delegates: 1

ItemListRefresh: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentSalvage*)
  • System.IAsyncResult BeginInvoke(FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentSalvage*, System.AsyncCallback, object)

FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentStatus: 1

StatusCharaView: 2

  • bool IsAnimationPaused()
  • void ToggleAnimationPlayback(bool)

FFXIVClientStructs.FFXIV.Client.UI.Agent.AgentTryon: 1

TryonCharaView: 2

  • bool IsAnimationPaused()
  • void ToggleAnimationPlayback(bool)

FFXIVClientStructs.FFXIV.Client.UI.Misc.BannerModule.Delegates: 1

GetNextId: 2

  • byte Invoke(FFXIVClientStructs.FFXIV.Client.UI.Misc.BannerModule*)
  • byte EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Client.UI.Misc: 2

BannerModule: 1

  • byte GetNextId()

CharaView: 2

  • bool IsAnimationPaused()
  • void ToggleAnimationPlayback(bool)

@github-actions github-actions bot added the breaking change PR contains breaking changes and wont be merged before a new patch label Mar 9, 2025
@wolfcomp wolfcomp merged commit f230e3e into aers:7.2_prep Mar 9, 2025
3 of 4 checks passed
@Haselnussbomber Haselnussbomber deleted the remove-todos branch March 9, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change PR contains breaking changes and wont be merged before a new patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants