Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HouseId, AgentHousingSignboard, AgentHousingPortal #1317

Merged
merged 4 commits into from
Mar 9, 2025

Conversation

Haselnussbomber
Copy link
Contributor

@Haselnussbomber Haselnussbomber commented Mar 9, 2025

  • Adds the Client::Game::HouseId struct we've been working on in the Dalamud Discord.
  • Adds Client::Game::UI::Map.AddHousingMarker
  • Adds Client::UI::Agent::AgentHousingSignboard.ReadPacket
  • Adds Client::UI::Agent::AgentHousingPortal.ReadPacket

(I intend to maybe hook those in the future)

@github-actions github-actions bot added the breaking change PR contains breaking changes and wont be merged before a new patch label Mar 9, 2025
@github-actions github-actions bot added the requested changes Changes requested through comments label Mar 9, 2025
@github-actions github-actions bot removed the requested changes Changes requested through comments label Mar 9, 2025
Copy link
Contributor

github-actions bot commented Mar 9, 2025

Breaking Changes

Member exists in left but not in right

FFXIVClientStructs.FFXIV.Client.Game.HousingManager.Delegates: 2

GetCurrentIndoorHouseId: 2

  • long Invoke(FFXIVClientStructs.FFXIV.Client.Game.HousingManager*)
  • long EndInvoke(System.IAsyncResult)

GetOwnedHouseId: 2

  • long Invoke(FFXIVClientStructs.FFXIV.Client.Game.EstateType, int)
  • long EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Client.Game: 4

HousingManager: 2

  • long GetCurrentIndoorHouseId()
  • long GetOwnedHouseId(FFXIVClientStructs.FFXIV.Client.Game.EstateType, int)

IndoorTerritory: 1

  • long HouseId

OutdoorTerritory: 1

  • long HouseId

WorkshopTerritory: 1

  • long HouseId

@Haselnussbomber Haselnussbomber changed the title Add HouseId struct Add HouseId, AgentHousingSignboard, AgentHousingPortal Mar 9, 2025
@wolfcomp wolfcomp merged commit b422b6e into aers:7.2_prep Mar 9, 2025
4 of 5 checks passed
@Haselnussbomber Haselnussbomber deleted the add-houseid-struct branch March 9, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change PR contains breaking changes and wont be merged before a new patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants