Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper python module destination #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghostshadow
Copy link

Since the maintainer of the AUR package (https://aur.archlinux.org/packages/opencamlib-git) appears to have difficulties keeping up with patching the python module install path (my install was broken again), I thought it should actually be fixed upstream.
I also noted the issue of the Debian package maintainer (#157 ) and this should improve the situation there as well.

The "FindPython3" CMake module already provides variables containing the paths for installing modules into (https://cmake.org/cmake/help/latest/module/FindPython3.html, Python3_SITELIB and Python3_SITEARCH), so why not use these directly? This way it should be a lot more portable and not require the execute_process.

Note: Since site.getsitepackages() only contains one element on my system, the index [-2] is out of bounds resulting in an exception. This caused the python module being installed to /opencamlib, which, I think, is even worse than /usr/lib/opencamlib, as it was in the version before 🥲

@aewallin
Copy link
Owner

aewallin commented Feb 3, 2025

any idea why the CI builds/tests all fail? something changed on github side?

@vespakoen
Copy link
Collaborator

I am fine with using Python3_SITEARCH.

Looks like boost download link changed causing the builds to break, I will update it to a newer one and see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants