fix checkstyle errors #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouphi
approved these changes
Jun 30, 2022
Izzzu
approved these changes
Jun 30, 2022
cpeeyush
approved these changes
Jun 30, 2022
|
FYI, ignoring failing check Error message:
|
pkirch
added a commit
that referenced
this pull request
Jul 4, 2022
…#1565) * 04.0-file-transfer: add automated test in sample 04.0 (#262) * add missing sample output to README.md * add missing property `edctype` to filetransfer.json * add missing toBuilder() method to DataRequest.java * add missing toBuilder() method to DataAddress.java * cache value for build root * test: add unit tests: verifyCopy, verifyDeepCopy, verifyToBuilder * samples: fix checkstyle errors (#315) * move DataAddress change code into test + restore previous behavior for Builder.properties() * move DataRequest change code into test + restore previous behavior for Builder.properties() * revert whitespace * reverted bug fix for shallow copy incl. regression tests * reverted whitespace * reverted whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR fixes checkstyle errors in
FileTransferSampleTest.java.Why it does that
Checkstyle CI in upstream is failing.
Further notes
Downstream and upstream issues have been files to cover uncaught checkstyle errors.
Linked Issue(s)
Closes #252
Checklist
no-changelog)