feat: refactor configuration #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanmarko
requested review from
0xaatif,
Ekleog-Polygon and
Freyskeyd
and removed request for
a team
|
Resolves #43 |
Ekleog-Polygon
previously approved these changes
Feb 13, 2025
There was a problem hiding this comment.
LGTM! Though you'll likely need to wrangle with git, considering this looks like it's built on an older version of #29
atanmarko
dismissed
Ekleog-Polygon’s stale review
The base branch was changed.
There is nothing one cherry-pick and force push can not resolve 😜 |
atanmarko
force-pushed
the
feat/refactor-configuration
branch
from
4492d64 to
e918f8f
Compare
Ekleog-Polygon
previously approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Showing with 205 additions and 1,896 deletions.
Considering the PR size, guess I'll review the PR again and not the "compare changes" button 😝
Maybe, in the future, keep the PR as draft until the base has landed on main, to avoid such double-reviews?
Anyway, LGTM!
Ekleog-Polygon
approved these changes
Feb 13, 2025
Freyskeyd
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor dependencies between configurations.
aggchain-proof-serviceis now separate service.Resolves #43
PR Checklist: