Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor and update proof types #87

Draft
wants to merge 1 commit into
base: bridge-proof-remaining
Choose a base branch
from

Conversation

atanmarko
Copy link
Contributor

Description

Update proof types to match latest proto changes.

Fixes #86

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko added this to the v0.3.0-provers milestone Mar 6, 2025
@atanmarko atanmarko self-assigned this Mar 6, 2025
@atanmarko atanmarko force-pushed the feat/update-proof-types branch from dc3368c to 01ca498 Compare March 6, 2025 15:04
@atanmarko atanmarko marked this pull request as ready for review March 6, 2025 15:04
@atanmarko atanmarko requested a review from a team as a code owner March 6, 2025 15:04
Copy link
Contributor

@iljakuklic iljakuklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me code-wise. However, I am missing some context regarding the motivation for these changes.

@atanmarko
Copy link
Contributor Author

Note: put to draft to rebase on top of #84

@atanmarko atanmarko force-pushed the feat/update-proof-types branch from 357c80b to be9a358 Compare March 10, 2025 17:07
@atanmarko atanmarko changed the base branch from main to bridge-proof-remaining March 10, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update aggkit-prover request chain according to latest proto changes
3 participants