Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and utilize countdown widget (for temporary deployments) #198

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use countdown widget in main notebook
edan-bainglass committed Mar 4, 2025
commit 25052d5c77f4bd8c7ae485e857f04db4707d5956
2 changes: 1 addition & 1 deletion home/widgets.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""AiiDAlab basic widgets."""

from datetime import datetime
import subprocess
from datetime import datetime
from threading import Timer

import ipywidgets as ipw
20 changes: 20 additions & 0 deletions start.ipynb
Original file line number Diff line number Diff line change
@@ -46,6 +46,26 @@
" parsed_url = urlparse.parse_qs(url.query)"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"from yaml import safe_load\n",
"\n",
"from home.widgets import CountDownWidget\n",
"\n",
"# For temporary deployments (e.g. demo server), duration is read from a local\n",
"# config file. This will initiate the countdown widget.\n",
"demo_server_config_file = Path.home() / \".aiidalab\" / \"demo-server-config.yml\"\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the QEapp, we don't want to hardcode the demo-server in the app, so I would suggest using aiidalab-home.yaml, or aiidalab.yaml directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is explicitly for demo servers (not our demo server, but for demo servers)

"if demo_server_config_file.exists():\n",
" demo_server_config = safe_load(demo_server_config_file.read_text())\n",
" countdown = CountDownWidget(duration=demo_server_config.get(\"duration\", \"12:00:00\"))\n",
Copy link
Member

@superstar54 superstar54 Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change duration to a better name, e.g., container_lifetime
  • if the lifetime does not set explicitly in the config file, the default value should be a very long time (e.g., 10 years), instead of 12:00:00.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, if the duration is not set in the config file, there should be no countdown widget deployed. I will adjust the conditional.

" countdown.start()\n",
" display(countdown)"
]
},
{
"cell_type": "code",
"execution_count": null,
Loading