Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiidalab-home repo rename #102

Merged
merged 4 commits into from
Dec 8, 2022
Merged

aiidalab-home repo rename #102

merged 4 commits into from
Dec 8, 2022

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 8, 2022

No description provided.

@unkcpz unkcpz requested a review from yakutovicha December 8, 2022 14:18
yakutovicha
yakutovicha approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @unkcpz 👍

@unkcpz
Copy link
Member Author

unkcpz commented Dec 8, 2022

Wierd, it build find in my computer but here it fails with another issue.

@yakutovicha
Copy link
Member

Wierd, it build find in my computer but here it fails with another issue.

Yes, not sure what it means:

packaging.version.InvalidVersion: Invalid version: 'stable'

@unkcpz
Copy link
Member Author

unkcpz commented Dec 8, 2022

Okay, found the issue. It was caused by the new version of package packaging, I pinned it to <22 and it works. I can also reproduce the issue after updating the packaging to 22.0.
We still need to take a close look at it, I guess it might that stable is some sort "legacy version" label and removed from the packaging by pypa/packaging#407.

@unkcpz unkcpz requested a review from yakutovicha December 8, 2022 15:55
@unkcpz
Copy link
Member Author

unkcpz commented Dec 8, 2022

@yakutovicha okay to merge this?

@unkcpz
Copy link
Member Author

unkcpz commented Dec 8, 2022

Open issue for packaging version at #103

@yakutovicha
Copy link
Member

I let you merge this, @unkcpz

@unkcpz unkcpz merged commit 6f77ebc into master Dec 8, 2022
@unkcpz unkcpz deleted the fix/home-build branch December 8, 2022 16:10
@danielhollas
Copy link
Contributor

Okay, found the issue. It was caused by the new version of package packaging, I pinned it to <22 and it works. I can also reproduce the issue after updating the packaging to 22.0.
We still need to take a close look at it, I guess it might that stable is some sort "legacy version" label and removed from the packaging by pypa/packaging#407.

I discovered the the same issue in aiidalab repo aiidalab/aiidalab#339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakutovicha yakutovicha yakutovicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unkcpz @yakutovicha @danielhollas