Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aiidalab package #138

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Jul 5, 2024

This update includes:

Also includes basic repo cleanup:

  • Remove unneeded pre-commit hooks
  • trivial CI updates
  • update links in README

pre-commit==3.6.0
packaging<22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pin is part of aiidalab dependencies and so it is not needed here.

@@ -3,20 +3,10 @@ ci:
autoupdate_schedule: quarterly

repos:
- repo: https://github.com/psf/black
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no python files in this repo.

hooks:
- id: check-yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple check for the validity of yaml files

@danielhollas
Copy link
Contributor Author

CC @yakutovicha can you please add the deployment group in repo settings? I don't have basic access to this repo (cannot even tag people for review)

@danielhollas
Copy link
Contributor Author

@yakutovicha friendly ping for review. :-)

Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @danielhollas, got lost in all the PRs for review. It is good to go for me 👍

@danielhollas danielhollas merged commit 24def98 into aiidalab:main Nov 26, 2024
1 check passed
@danielhollas danielhollas deleted the update-aiidalab branch November 26, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the latest packaging version check
2 participants