-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix performance regression #102
Conversation
Allows for the association of a container with an existing DB, or to uniquely refer to it. 🐛 This also fixes a bug, whereby config values were cached, but the cache was not cleared when re-initialising the container. To reduce the risk of such a problem, now only the whole configuration dictionary is cached, rather than each single config value.
Codecov Report
@@ Coverage Diff @@
## develop #102 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 1502 1502
=========================================
Hits 1502 1502
Continue to review full report at Codecov.
|
If the code coverage is uploaded multiple times for a single commit, then the coverage is simply overwritten.Thereofre, a single test run should be chosen.
I've also fixed the issue with codecov initially reporting lower test converage, caused by the fact that it was being uploaded (& overwritten) for every matrix run (and just by luck the windows tests are loaded last, which have the full test coverage) |
Thanks! Are you sure that it does not merge? You can see this in the tests for commit 1d7c389 that all pass with 100% coverage. So I suggest you remove the fix for the coverage and then we merge the actual bug fix |
Ah good, I was lead to believe otherwise lol |
Container.is_initialised
is a costly operation, loading the config JSON every time.In 1d7c389, the config is now called on every call to
loose_prefix_len
, leading to a massive performance degradation.This PR makes sure the
is_initialised
test is called only if the config has not already been loaded into memory.Before:
After: