-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] async'ify Credentials class #619
Comments
Is there a workaround for this at the moment? |
@mjmdavis the work around I used was to use a synchronous botocore call using the refresh method defined in https://www.pydoc.io/pypi/botocore-1.7.0/autoapi/credentials/index.html#credentials.RefreshableCredentials and update credentials in the aiosession for the async clients. |
@mannickutd Could you elaborate and maybe provide a code snippet? |
prefixing with infra as my experiment yielded a LOT of changes |
btw my PR needs to be re-done to be cleaner by delaying client creation to the |
just got permission to expose what our company has been using to resolve this issue internally: https://gist.github.com/thehesiod/05298c1c89c7b5a38da0abc4ccbed7b7 |
There are at least a couple underlying issues related to this class:
First one results in possible hangs of the main thread, while second one is broken because it's not await'ing the request of the client request.
The issue is that these are low-level in classes used by the Credential helper, and ultimately triggered by high level properties like
secret_key
,access_key
andtoken
. We need to find all the calls that will end up needing to be changed to async, and then figure a strategy of how to battle this. I'm afraid this is going to touch a LOT of botocore and greatly increase our footprint and amount of maintenance required.The text was updated successfully, but these errors were encountered: