-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocking call when loading credentials in Session.create_client #2
Comments
Thanks for thre report! On my project we explicitly pass key and secret as keyword argumens, so I missed this issue. I will take a look. Can we assume that credential loading happens only once? If so I think, spawning thread in order to read small file once is not worth effort. |
Yep only once, if it is OK for you I can cook a pach for this |
Sure, please do. |
Which |
ok I found out . it is |
Some credentials providers do blocking IO. Wrap all of them with a thread so we don't block the event loop. See issue aio-libs#2
hmm, I remember there being a comment that the credentials are periodically updated. I looked into this and it was not a trivial fix |
closing in favor of #619 |
in
aiobotocore.session.Session
we make use ofself.get_credentials
that is implemented in botocore.session.Session.This method's implementation depends on credential provider config, and in some cases it can block while doing IO, for instance when loading from ini file or when using a IAM role
The text was updated successfully, but these errors were encountered: