Add a __class_getitem__ hook (PEP 585) #173
Conversation
This makes it possible to use FrozenClass as a generic in typehinting without having to use `from __future__ import annotations` or forward references.
Codecov Report
@@ Coverage Diff @@
## main #173 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 54 59 +5
Branches 6 6
=========================================
+ Hits 54 59 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
frozenlist/__init__.py
Outdated
| # Python 3.9 PEP 585 | ||
| __class_getitem__ = classmethod(types.GenericAlias) | ||
| except AttributeError: | ||
| pass |
There was a problem hiding this comment.
Could you please just return self if GenericAlias doesn't exist?
Another thing is the exception usage here.
The code is 100% correct but if sys.version_info >= (3, 9): provides more information to reader what is the expected version with desired behavior and works much better with mypy and other type checkers.
asvetlov
force-pushed
the
class_generic
branch
from
d17b977 to
b92916d
Compare
This makes it possible to use FrozenClass as a generic in typehinting
without having to use
from __future__ import annotationsor forwardreferences.
Closes #172