Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to sbt 1.3.3, mima to 0.6.1, sbt-dependency-graph… #2780

Merged
merged 1 commit into from
Oct 28, 2019
Merged

build: update to sbt 1.3.3, mima to 0.6.1, sbt-dependency-graph… #2780

merged 1 commit into from
Oct 28, 2019

Conversation

jrudolph
Copy link
Contributor

Coursier needs to be turned off for sbt-dependency-graph to work correctly
until sbt/sbt#4706 is fixed.

This was referenced Oct 23, 2019
Closed
Closed
@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Oct 23, 2019
This was referenced Oct 23, 2019
Closed
Closed
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Oct 23, 2019
@akka-ci
Copy link

akka-ci commented Oct 23, 2019

Test PASSed.

@jrudolph
Copy link
Contributor Author

Blocked on lightbend-labs/mima#422

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Oct 23, 2019
@akka-ci
Copy link

akka-ci commented Oct 23, 2019

Test PASSed.

@jrudolph jrudolph requested a review from johanandren October 23, 2019 10:08
@jrudolph jrudolph mentioned this pull request Oct 24, 2019
Closed
johanandren
johanandren approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrudolph
build: update to sbt 1.3.3, mima to 0.6.1, sbt-dependency-graph to 0.…
e2a0748 
…10.0-RC1

Coursier needs to be turned off for sbt-dependency-graph to work correctly
until sbt/sbt#4706 is fixed.
@jrudolph
Copy link
Contributor Author

Removed the workaround again, since lightbend-labs/mima#422 seems to resolved for now.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Oct 28, 2019
@akka-ci
Copy link

akka-ci commented Oct 28, 2019

Test PASSed.

@jrudolph jrudolph changed the title build: update to sbt 1.3.3, mima to 0.6.1, sbt-dependency-graph to 0.10.0-RC1 build: update to sbt 1.3.3, mima to 0.6.1, sbt-dependency-graph… Oct 28, 2019
@jrudolph jrudolph merged commit bf7123b into akka:master Oct 28, 2019
@jrudolph jrudolph deleted the update-deps branch October 28, 2019 11:01
@jrudolph jrudolph added this to the 10.1.11 milestone Oct 28, 2019
@jrudolph jrudolph mentioned this pull request Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
10.1.11
Development

Successfully merging this pull request may close these issues.
3 participants
@jrudolph @akka-ci @johanandren