#1088 MultiNode tests can now be skipped by specifying a SkipReason

akkadotnet · Aug 8, 2015 · 75f966c · 75f966c
1 parent e6ca2ac
commit 75f966c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/src/core/Akka.MultiNodeTestRunner.Shared/NodeTest.cs b/src/core/Akka.MultiNodeTestRunner.Shared/NodeTest.cs
@@ -13,6 +13,7 @@ public class NodeTest
         public string TestName { get; set; }
         public string TypeName { get; set; }
         public string MethodName { get; set; }
+        public string SkipReason { get; set; }
     }
 }
 
diff --git a/src/core/Akka.MultiNodeTestRunner/Discovery.cs b/src/core/Akka.MultiNodeTestRunner/Discovery.cs
@@ -65,7 +65,8 @@ private NodeTest GetTestDetails(ITestCaseDiscoveryMessage nodeTest)
                 Node = Convert.ToInt32(matches.Groups[2].Value),
                 TestName = matches.Groups[1].Value,
                 TypeName = nodeTest.TestClass.Class.Name,
-                MethodName = nodeTest.TestCase.TestMethod.Method.Name
+                MethodName = nodeTest.TestCase.TestMethod.Method.Name,
+                SkipReason = nodeTest.TestCase.SkipReason
             };
         }
 

diff --git a/src/core/Akka.MultiNodeTestRunner/Program.cs b/src/core/Akka.MultiNodeTestRunner/Program.cs
@@ -75,6 +75,12 @@ static void Main(string[] args)
 
                     foreach (var test in discovery.Tests.Reverse())
                     {
+                        if (!string.IsNullOrEmpty(test.Value.First().SkipReason))
+                        {
+                            PublishRunnerMessage(string.Format("Skipping test {0}. Reason - {1}", test.Value.First().MethodName, test.Value.First().SkipReason));
+                            continue;
+                        }
+
                         PublishRunnerMessage(string.Format("Starting test {0}", test.Value.First().MethodName));
 
                         var processes = new List<Process>();

diff --git a/src/core/Akka.MultiNodeTests/MultiNodeFact.cs b/src/core/Akka.MultiNodeTests/MultiNodeFact.cs
@@ -27,7 +27,7 @@ public override string Skip
             get
             {
                 return ExecutedByMultiNodeRunner.Value
-                    ? null
+                    ? base.Skip
                     : "Must be executed by multi-node test runner";
             }
             set { base.Skip = value; }