Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player closure fix #1562

Merged
merged 1 commit into from
Dec 16, 2015
Merged

Player closure fix #1562

merged 1 commit into from
Dec 16, 2015

Conversation

rogeralsing
Copy link
Contributor

This PR fixes a non closed over Self reference in the Remote.TestKit Player.
Self is not safe to use in continuations as the Self property is pointing to the currently active context.

From ActorBase.cs

protected IActorRef Self { get { return HasBeenCleared ? _clearedSelf : Context.Self; } }

protected static IActorContext Context
{
      get
      {
         var context = InternalCurrentActorCellKeeper.Current;
         if (context == null)
            throw new NotSupportedException(
                        "There is no active ActorContext, this is most likely due to use of async operations from within this actor.");

         return context.ActorHasBeenCleared ? null : context;
     }
}

@Aaronontheweb
Copy link
Member

Failure caused by the RemoteRoundRobinSpec, which is the usual suspect for failures

Aaronontheweb added a commit that referenced this pull request Dec 16, 2015
@Aaronontheweb Aaronontheweb merged commit 19cf5a3 into akkadotnet:dev Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants