Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Added blurb about updated PRs and build server #1643

Merged
merged 1 commit into from
Jan 13, 2016

Conversation

sean-gilliam
Copy link
Member

This PR adds a section to the Contributing.md document instructing users
how to update git timestamps in order for the build server to pick up
updated PRs.

@Aaronontheweb
Copy link
Member

@sean-gilliam can you run the tests locally and let me know if there are any API changes that need to be approved? Going to be a bit of a transition period here while the in-flight PRs that haven't rebased on dev all hit this failure http://getakka.net/docs/akka-developers/public-api-changes

@sean-gilliam sean-gilliam force-pushed the contributing branch 2 times, most recently from 238b53f to 1394cce Compare January 13, 2016 22:20
This PR adds a section to the Contributing.md document instructing users
how to update git timestamps in order for the build server to pick up
updated PRs.
Aaronontheweb added a commit that referenced this pull request Jan 13, 2016
[docs] Added blurb about updated PRs and build server
@Aaronontheweb Aaronontheweb merged commit 752289e into akkadotnet:dev Jan 13, 2016
@sean-gilliam
Copy link
Member Author

@Aaronontheweb I ran the tests as outlined in that document, but it didn't generate a received.txt file to compare against. Do the tests generate that file if no code changes are made?

@Aaronontheweb
Copy link
Member

yes, that file will always be generated but I think it gets deleted if there are no changes

@Aaronontheweb
Copy link
Member

There could also be some funkiness going on with line endings and other stuff

@sean-gilliam
Copy link
Member Author

gotcha

@sean-gilliam sean-gilliam deleted the contributing branch January 13, 2016 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants