Multi level Hocon config #254
Conversation
* Implemented multi level hocon test
| var config3 = ConfigurationFactory.ParseString(hocon3); | ||
| var config4 = ConfigurationFactory.ParseString(hocon4); | ||
|
|
||
| var config = config1.WithFallback(config2.WithFallback(config3.WithFallback(config4))); |
There was a problem hiding this comment.
^ se above, creating multi level hocon
Problems possibly arise if one would do:
config1.WithFallback(config2).WithFallback(config3).WithFallback(config4)
since that would create an incorrect order of fallbacks.
config1 would have config2 as fallback
that new config would have config3 as fallback
Here is where things break down, since config2 does not know about config3.
This is most likely the cause of multi level hocon we have had before.
or?
cc. @Aaronontheweb
There was a problem hiding this comment.
@rogeralsing one of your tests should include the original Pigeon.conf as the implicit final fallback and test to make sure that a value not present in any of the user-defined confs still appears there.
There was a problem hiding this comment.
@rogeralsing yeah, that's probably where the issue is.
Here's where the real problem occurs then: https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka.Remote/RemoteActorRefProvider.cs#L30
https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka/Actor/Settings.cs#L21
Using var config = config1.WithFallback(config2) as an example here, the WithFallback on either of those two lines effectively wipes out config2 from the user's application.
So either we need to change WithFallback to append a new config to the end of the linked list (which would make config1.WithFallback(config2).WithFallback(config3).WithFallback(config4) work), or add a new method that explicitly does that and change these two calls to use it instead. WithFinalFallback or something like that.
There was a problem hiding this comment.
Yes, WithFallback should be changed to work in a fluent way, that is what one would expect from it.
* Hocon Parser now returns a `HoconRoot` , (`HoconValue` and a list of `HoconSubstitution`)
## Breaking change!
`new ActorSystem("name")` now calls `ConfigurationFactory.Load()` which in turn gets the config from App/Web.config
Earlier versions only used Pigeion.config if no config was supplied.
This change aligns more to Akka.
|
cc. @Aaronontheweb fluent multilevel hocon config |
|
Good deal! |
Multi level Hocon config
…ActorSystem start
HoconRoot, (HoconValueand a list ofHoconSubstitution)Breaking change!
ActorSystem.Create("name")now callsConfigurationFactory.Load()which in turn gets the config from App/Web.configEarlier versions only used Pigeion.config if no config was supplied.
This change aligns more to Akka.
This only affects systems created w/o a config, effect for real users should be minimal
ActorSystem.Create("name", config)still behaves as before.