Removed Reentrancy behavior #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build error, is that something else or what causes that? |
|
Looks like a nuget issue |
|
I'm all for it, but doesn't this change the API? Where do we draw the line? |
|
Yes it does change the API, but hopefully reentrancy was not widely used, and there is just too much noise around it that steals focus from the project itself. |
|
Agree. |
|
Agree |
|
Pulling this in. |
Aaronontheweb
added a commit
that referenced
this pull request
Apr 28, 2015
Removed Reentrancy behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all traces of async reentrancy.