Remove omsagent from build image #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craddm
requested review from
martintoreilly,
jemrobinson and
JimMadge
as code owners
jemrobinson
reviewed
Feb 6, 2024
deployment/secure_research_desktop/cloud_init/cloud-init-buildimage-ubuntu-2004.mustache.yaml
Outdated
Show resolved
Hide resolved
jemrobinson
approved these changes
Feb 9, 2024
JimMadge
requested changes
Feb 9, 2024
deployment/secure_research_desktop/cloud_init/cloud-init-buildimage-ubuntu-2004.mustache.yaml
Outdated
Show resolved
Hide resolved
|
Great work identifying this @craddm. That is a lot of issue fixed at once! 🎉 |
jemrobinson
reviewed
Feb 13, 2024
deployment/secure_research_desktop/cloud_init/cloud-init-buildimage-ubuntu-2004.mustache.yaml
Show resolved
Hide resolved
deployment/secure_research_desktop/cloud_init/cloud-init-buildimage-ubuntu-2004.mustache.yaml
Show resolved
Hide resolved
jemrobinson
reviewed
Feb 14, 2024
| @@ -405,6 +405,12 @@ runcmd: | |||
| # Run installation tests | |||
| - python3 /opt/build/check_installation.py || die "Installation check failed!"; | |||
|
|
|||
| # Remove Linux omsagent before generalising the image | |||
| - echo ">=== $(date +%s) Removing Linux omsagent ===<" | |||
| - wget https://raw.githubusercontent.com/Microsoft/OMS-Agent-for-Linux/c7e1a8f923844f989c8aa7957cee0e89708d821f/installer/scripts/onboard_agent.sh | |||
jemrobinson
reviewed
Feb 14, 2024
deployment/secure_research_desktop/cloud_init/cloud-init-buildimage-ubuntu-2004.mustache.yaml
Show resolved
Hide resolved
…image-ubuntu-2004.mustache.yaml Co-authored-by: James Robinson <[email protected]>
JimMadge
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integrationrather than515 foobar).develop.'[WIP]'to the title if needed (if you're not yet ready to merge)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>for Powershell).Adds a step to the VM image building process to remove omsagent before the deprovisioning and generalizing of the image. Leaving the omsagent in place prevents its proper use on VMs deployed using the image. As per Microsoft's instructions, a shell script is downloaded and used to uninstall the agent.
VMs deployed using the images can now be successfully connected to the Log Analytics workspace.
This PR also adds a system dependency required for the use of the R package
igraph-libglpk-dev.🌂 Related issues
Closes 2 issues related to update management and one other issue with the VM build image
Closes #1403
Closes #1372
Closes #1730
🔬 Tests
Built a new image, deployed a VM based on this image and validated that it is successfully connected to the Log Analytics workspace:
