fix: #455 latest code was not waiting for nodemon #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydonelson
approved these changes
Apr 18, 2023
| constructor(execConfig) { | ||
| this.execConfig = execConfig; | ||
| } | ||
|
|
||
| execCommand() { | ||
| nodemon(this.execConfig); | ||
| return new Promise(() => { | ||
| nodemon({verbose: true, ...this.execConfig}) |
There was a problem hiding this comment.
Just looking for clarification here, changes look good to me... a little fuzzy on how this makes the nodemon call synchronous now, if the app wasn't waiting on this line before, why would it be now?
There was a problem hiding this comment.
there is an await where execCommand() is getting called in the index file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#455
nodemon is used to launch a new debug session when files get modified/updated. for some reason v2.29.1 was not waiting for the nodemon and exiting the process. Solution here is to wrap it in a promise and waiting for the promise to resolve. Also, converted the helper.js file to typescript.
We'll need to add some integration test to make sure this doesn't regress in the future, but wanted to get the fix out ASAP, given this is a breaking bug...
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.