Add ABI-encoding feature #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahangsu
force-pushed
the
abi-encoding
branch
2 times, most recently
from
f90e887 to
046b3db
Compare
ahangsu
force-pushed
the
abi-encoding
branch
from
14cc15c to
7e6ee1a
Compare
ahangsu
force-pushed
the
abi-encoding
branch
from
57d7992 to
6f0e247
Compare
jasonpaulos
reviewed
Sep 29, 2021
encoding/abi/abi.go
Outdated
| "github.com/algorand/go-algorand/data/abi" | ||
| ) | ||
|
|
||
| type Value struct { |
There was a problem hiding this comment.
@algorandskiy mentioned using struct embedding (e.g. type Value struct { abi.Value }) to avoid having to declare methods again, such as Encode().
But would a simple type assignment work as well? E.g. type Value = abi.Value
There was a problem hiding this comment.
Wow looks like it works @ahangsu
I tried type aliasing (type Value abi.Value) and it did not work
There was a problem hiding this comment.
That works, it can also remove the redundant method wrapper, leaving only necessary constructor, Decode and TypeFromString. Nice one :-)
algorandskiy
approved these changes
Sep 29, 2021
jasonpaulos
added a commit
that referenced
this pull request
Oct 4, 2021
This reverts commit fdcd3f6.
jasonpaulos
added a commit
that referenced
this pull request
Oct 4, 2021
This reverts commit 48a72ca.
algoidurovic
pushed a commit
to algoidurovic/go-algorand-sdk
that referenced
this pull request
Nov 1, 2021
This reverts commit 48a72ca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the corresponding feature to #236.
We added a wrapper around the implementation in go-algorand merged in algorand/go-algorand#2807, and exported necessary interface in the sdk.