Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Migrate v1 algod dependencies to v2 in cucumber tests #434

Merged
merged 18 commits into from
Nov 23, 2022

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Nov 9, 2022

Migrates v1 algod usage in cucumber integration tests to use v2. Also deletes some unused steps relating to v1 APIs.

SDK Testing PR: algorand/algorand-sdk-testing#249

@algochoi algochoi changed the title Migrate v1 algod dependencies to v2 in cucumber tests Tests: Migrate v1 algod dependencies to v2 in cucumber tests Nov 10, 2022
@algochoi algochoi requested a review from ahangsu November 15, 2022 15:53
@algochoi algochoi marked this pull request as ready for review November 21, 2022 15:54
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems straightforward, looks generally good to me

algochoi and others added 2 commits November 22, 2022 17:22
Co-authored-by: algochoi <[email protected]>
@algochoi algochoi merged commit 9b0c852 into develop Nov 23, 2022
@algochoi algochoi deleted the remove-v1-tests branch November 23, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants