handle is left open in importRootKeys (#3039)

algonautshant · web-flow · commit da60399c3b38 · 2021-10-12T15:39:20.000-04:00
## Summary

The database handle is not closed in this code path.
In normal situations, this passes unnoticed, since it will be closed once the test terminates. However, when running the test multiple times, the OS will complain about too many open files. 

## Test Plan
This is a test infrastructure fix.
diff --git a/test/framework/fixtures/libgoalFixture.go b/test/framework/fixtures/libgoalFixture.go
@@ -170,6 +170,7 @@ func (f *LibGoalFixture) importRootKeys(lg *libgoal.Client, dataDir string) {
 				f.failOnError(err, "couldn't import secret: %v")
 			}
 			accountsWithRootKeys[root.Address().String()] = true
+			handle.Close()
 		} else if config.IsPartKeyFilename(filename) {
 			// Fetch a handle to this database
 			handle, err = db.MakeErasableAccessor(filepath.Join(keyDir, filename))

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,7 @@ func (f LibGoalFixture) importRootKeys(lg libgoal.Client, dataDir string) {`
`170`	`170`	`f.failOnError(err, "couldn't import secret: %v")`
`171`	`171`	`}`
`172`	`172`	`accountsWithRootKeys[root.Address().String()] = true`
	`173`	`+ handle.Close()`
`173`	`174`	`} else if config.IsPartKeyFilename(filename) {`
`174`	`175`	`// Fetch a handle to this database`
`175`	`176`	`handle, err = db.MakeErasableAccessor(filepath.Join(keyDir, filename))`